Skip to content

Fix #148: Remove & replace python setup.py test#149

Merged
s-celles merged 1 commit intopython-semver:masterfrom
tomschr:bugfix/148-rm-setup.py-test
Oct 2, 2019
Merged

Fix #148: Remove & replace python setup.py test#149
s-celles merged 1 commit intopython-semver:masterfrom
tomschr:bugfix/148-rm-setup.py-test

Conversation

@tomschr
Copy link
Member

@tomschr tomschr commented Oct 2, 2019

This PR fixes #148 and contains:

As tox discouraged using "python setup.py test", we shouldn't recommend that in our documentation. Replacing it with tox.

@tomschr
Fix python-semver#148: Remove & replace python setup.py test
f834d12 
As tox discouraged using "python setup.py test", we shouldn't
recommend that in our documentation. Replacing it with "tox".
ppkt
ppkt approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@ppkt ppkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Would you like to also update setup.py and remove invoking tox (and use pytest instead)?

@tomschr
Copy link
Member Author

tomschr commented Oct 2, 2019 •
edited
Loading

@ppkt

LGTM :) Would you like to also update setup.py and remove invoking tox (and use pytest instead)?

Just to clarify: you mean, changing the Tox class in setup.py and replacing the tox command with pytest, right?

Why not remove the class alltogether? Why not run pytest or tox directly instead of the detour with setup.py? IMHO, it doesn't make sense to run python setup.py test.

@ppkt
Copy link
Member

ppkt commented Oct 2, 2019

@tomschr yes, I think python setup.py test command should run tests for current Python instance. However, it looks like there is a discussion about removing test command at all: pypa/setuptools#1684
Maybe let's leave it as it is for now :)

@tomschr
Copy link
Member Author

tomschr commented Oct 2, 2019

@ppkt

Maybe let's leave it as it is for now :)

Ok, I'm fine with that. 😉 👍

@s-celles s-celles merged commit 5fb1011 into python-semver:master Oct 2, 2019
@tomschr tomschr deleted the bugfix/148-rm-setup.py-test branch October 2, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppkt ppkt ppkt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Doc: Remove recommendation of "setup.py test" in Contribute Section

3 participants

@tomschr @ppkt @s-celles