Fixes #109 and add iterator to VersionInfo#124
Merged
s-celles merged 1 commit intopython-semver:masterfrom Mar 24, 2019
Merged
Conversation
* Add Karl to CONTRIBUTORS * Use version fixture in test function test_version_info_should_be_iterable based on the work of Karol Werner in PR python-semver#109
Member
Member
Author
|
Wow, that was quick! 😆 Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #109 by Karol Werner and contains:
CONTRIBUTORSfile and added him as primary author.versionfixture in test functiontest_version_info_should_be_iterable._astuple()function and created the tuple manually.I think, Karol's idea is useful as it allows to create a sequence with just
tuple(version)orlist(version)without using the (kind of) "private" member function_astuple().If the maintainers of this project find it useful, I suggest to close #109 as well (as it is related and contains a conflict).