refactor: optimize & improve maintainability of GitHub Action definition #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Debian Bullseye, it did not have a git version available that supported SSH key signing. SSH key signing was integrated in git version 2.34 and the highest version for Bullseye was 2.30. Through the backports repository, a version greater than 2.34 was made available but now bumping to Debian Bookworm, the available version is 2.39 in the base OS repository so no backports configuration required.
Updates the base container that runs the GitHub Action environment to python3.12 which enables users to specify and run build scripts that are python3.12 specific as python3.12 is now the latest stable version of python available and we were only providing `3.10`. Resolves: python-semantic-release#801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Optimize the Docker build and improve maintainability of the Docker GitHub Action
Rationale
In order to improve maintainability, I removed the additional defaults of the action and rely on the internal configuration defaults of the package instead.