Skip to content

fix: don't use commit_subject for tag pattern matching #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danth merged 1 commit into from
Jul 25, 2022
Merged

fix: don't use commit_subject for tag pattern matching #480

danth merged 1 commit into from
Jul 25, 2022

Conversation

@eifinger
Copy link
Contributor

@eifinger eifinger commented Jul 25, 2022

When commit_subject is configured but no commits are made by this lib or version_source=tag_only is used the changes in #476 introduced an error.

Now the commit_subject is only used to find the version pattern in commit messages and not in files or tags.

danth
danth approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@danth danth merged commit ac3f11e into python-semantic-release:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danth danth danth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eifinger @danth