fix: ignore dependencies versions bump when parsing version from commit logs - #472
Closed
browniebroke wants to merge 5 commits into
Closed
Conversation
browniebroke
marked this pull request as ready for review
July 14, 2022 22:02
browniebroke
force-pushed
the
fix/version-parsing-commit
branch
from
July 14, 2022 22:03
fb57492 to
9e9a9bc
Compare
browniebroke
force-pushed
the
fix/version-parsing-commit
branch
from
July 14, 2022 22:11
65c7968 to
fb57492
Compare
Contributor
|
I tested it in my repo and it works: https://github.com/eifinger/here_routing/runs/7353567801?check_suite_focus=true |
Contributor
|
@browniebroke I just had a new run with your changes and it broke. https://github.com/eifinger/here_routing/runs/7389213534?check_suite_focus=true Your changes did not account for a custom commit_subject: |
Contributor
Author
|
Ok, thanks for the feedback! I didn't know about this option, I guess that explain why I'll see if I can take this into account 👍🏻 |
Contributor
Author
|
Please chek out #476 for a more up-to-date fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #442