fix: prerelease tag in version patterns #466
Conversation
Delay construction of version and release patterns until runtime. This will allow to use non-default prerelease tag.
danth
left a comment
danth
left a comment
There was a problem hiding this comment.
What is the benefit of this vs what we had previously?
We actually had this exact issue in one of our uses. As the code currently stands, it is not possible to override the pre-release tag using cli flags and only works through changing it in the config files. The commit here appears to fix that issue since it does the check after init |
|
@saseith is right. Without this change, the "release_version_regex" and "version_regex" are assigned during the module import. Thus the "prerelease_tag" value used in the patterns will be the one available during the import time, which is before the runtime and before overwriting the config with values from the CLI. |
|
I see; will merge this now |
3 participants
Delay construction of version and release patterns until runtime.
This will allow to use non-default prerelease tag.