Fix monorepo parser options validation #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejedi365
pushed a commit
to guillaumecherel/python-semantic-release
that referenced
this pull request
Dec 14, 2025
…utside dir path matches Resolves: python-semantic-release#1382
codejedi365
force-pushed
the
fix/monorepo-parser-path-filters
branch
from
de6e687 to
1eca9d4
Compare
codejedi365
pushed a commit
to guillaumecherel/python-semantic-release
that referenced
this pull request
Dec 14, 2025
…utside dir path matches Resolves: python-semantic-release#1382
codejedi365
force-pushed
the
fix/monorepo-parser-path-filters
branch
from
1eca9d4 to
b626e34
Compare
codejedi365
pushed a commit
to guillaumecherel/python-semantic-release
that referenced
this pull request
Dec 14, 2025
…utside dir path matches Resolves: python-semantic-release#1382
codejedi365
force-pushed
the
fix/monorepo-parser-path-filters
branch
from
b626e34 to
2831207
Compare
codejedi365
pushed a commit
to guillaumecherel/python-semantic-release
that referenced
this pull request
Dec 14, 2025
…utside dir path matches Resolves: python-semantic-release#1382
codejedi365
force-pushed
the
fix/monorepo-parser-path-filters
branch
from
2831207 to
bdad2ab
Compare
codejedi365
pushed a commit
to guillaumecherel/python-semantic-release
that referenced
this pull request
Dec 14, 2025
…utside dir path matches Resolves: python-semantic-release#1382
codejedi365
force-pushed
the
fix/monorepo-parser-path-filters
branch
from
bdad2ab to
f424893
Compare
codejedi365
pushed a commit
to guillaumecherel/python-semantic-release
that referenced
this pull request
Dec 14, 2025
…utside dir path matches Resolves: python-semantic-release#1382
codejedi365
force-pushed
the
fix/monorepo-parser-path-filters
branch
from
f424893 to
e1c5891
Compare
codejedi365
pushed a commit
to guillaumecherel/python-semantic-release
that referenced
this pull request
Dec 14, 2025
…utside dir path matches Resolves: python-semantic-release#1382
codejedi365
force-pushed
the
fix/monorepo-parser-path-filters
branch
from
e1c5891 to
3f232f3
Compare
codejedi365
pushed a commit
to guillaumecherel/python-semantic-release
that referenced
this pull request
Dec 14, 2025
…ide dir path matches (python-semantic-release#1382) Resolves: python-semantic-release#1382
codejedi365
force-pushed
the
fix/monorepo-parser-path-filters
branch
from
3f232f3 to
29c06ab
Compare
…ide dir path matches (python-semantic-release#1382) Resolves: python-semantic-release#1380
codejedi365
force-pushed
the
fix/monorepo-parser-path-filters
branch
from
29c06ab to
24ad90a
Compare
Contributor
🎉 This PR has been published as part of v10.5.3 🎉You can find more information about this release on the GitHub Releases page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
path_filtersfails to reference paths outside the current package subtree #1380Rationale
See #1380 (comment)
The pydantic field validators for
ConventionalCommitMonorepoParserOptionsare not being executed at all. This results in the path_filters not getting correctly resolved into the expected absolute paths.This is due to the decorator
@classmethodbeing applied on top of the decorator@field_validatoron the validator functions.How did you test?
See the steps to reproduce the error here: #1380 (comment)
Applying the fix in this PR fixes the final error.
How to Verify
PR Completion Checklist
Reviewed & followed the Contributor Guidelines
Changes Implemented & Validation pipeline succeeds
Commits follow the Conventional Commits standard
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)
Appropriate Unit tests added/updated
Appropriate End-to-End tests added/updated
Appropriate Documentation added/updated and syntax validated for sphinx build (see Contributor Guidelines)