Skip to content

fix(cmd-version): fix --print-tag result to match configured tag format #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codejedi365 merged 4 commits into from
Jan 11, 2025
Merged

fix(cmd-version): fix --print-tag result to match configured tag format #1134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6baf08
test(fixtures): add new trunk repo that has a different tag format
codejedi365 Jan 10, 2025
dedfafa
test(fixtures): add helper to extract config settings from repo actio…
codejedi365 Jan 10, 2025
02c2c73
test(cmd-version): expand testing of `--print-tag` & `--print-last-re…
codejedi365 Jan 10, 2025
b63b24b
fix(cmd-version): fix `--print-tag` result to match configured tag fo…
codejedi365 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/semantic_release/cli/commands/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,12 +516,8 @@ def version( # noqa: C901
gha_output.version = new_version
ctx.call_on_close(gha_output.write_if_possible)

# Make string variant of version && Translate to tag if necessary
version_to_print = (
str(new_version)
if not print_only_tag
else translator.str_to_tag(str(new_version))
)
# Make string variant of version or appropriate tag as necessary
version_to_print = str(new_version) if not print_only_tag else new_version.as_tag()

# Print the new version so that command-line output capture will work
click.echo(version_to_print)
Expand Down
Loading
Loading