Repository navigation
Framework Helper Rework - #52
Merged
Merged
Conversation
Collaborator
Author
|
I hate the yolo merge but oh well :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One day, when current high priority issues are done, we will parse route files (routing.py's, url.py's etc.) to find controllers so we can run it at scale with less false positives then we can use the apaptor pattern.
But until then, requiring users to point pyt at their controllers seems fine. We can do this with the template pattern instead, for now. In Pylons for instance, in a controller file anything without a leading underscore should have arguments marked as tainted. This and the flask helper function works great.
The Flask option is still the default, so the default behavior hasn't changed. I was running pyt on DjangoNV (a purposely vulnerable Django app) and it was missing a lot because I couldn't mark all args as tainted, this PR solves that.