Skip to content

Fix returned file descriptors getting closed immediately #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igo95862 merged 2 commits into from
Aug 8, 2026
Merged

Fix returned file descriptors getting closed immediately #121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50dc428
Fix returned file descriptors getting closed
luleyleo Aug 6, 2026
99e6d8d
Wrap fnctl call in check macro
luleyleo Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/sdbus/sd_bus_internals_message.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
License along with this library; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
#include <fcntl.h>
#include "sd_bus_internals.h"

void _SdBusMessage_set_messsage(SdBusMessageObject* self, sd_bus_message* new_message) {
Expand Down Expand Up @@ -800,6 +801,10 @@ static PyObject* _iter_basic(sd_bus_message* message, char basic_type) {
case 'h': {
int new_fd = 0;
CALL_SD_BUS_AND_CHECK(sd_bus_message_read_basic(message, basic_type, &new_fd));

// The fd is owned by the message and would be closed after the end of the message's lifetime
new_fd = CALL_SD_BUS_AND_CHECK(fcntl(new_fd, F_DUPFD_CLOEXEC, 3));

return PyLong_FromLong((long)new_fd);
break;
}
Expand Down