Fix returned file descriptors getting closed immediately - #121
Merged
Conversation
See `man "sd_bus_message_read_basic(3)"`
Collaborator
|
You are correct. The only issue I see that there is no error checking if |
Contributor
Author
Good point. So, technically, it would make sense to wrap the |
Collaborator
|
It can be renamed later. I already use that macro on functions not part of libsystemd: python-sdbus/src/sdbus/sd_bus_internals_bus.c Line 648 in f2b4865 |
Contributor
Author
|
I've added the check now. |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a DBus method returns a file handler (
h), the handler must be duplicated before the message is freed, otherwise the file will be closed before the Python client can do anything with it.See
man "sd_bus_message_read_basic(3)".