Fix code generator not defaulting to emit changed for properties

igo95862 · igo95862 · commit 98082ac4fa85 · 2024-10-26T21:28:10.000+01:00
Properties emit changed signals by default but for systemd this
is inverted as a flag is needed.
diff --git a/src/sdbus/interface_generator.py b/src/sdbus/interface_generator.py
@@ -432,21 +432,21 @@ def __repr__(self) -> str:
 
 
 class DbusPropertyIntrospection(DbusMemberAbstract):
-    _EMITS_CHANGED_MAP: \
-        Dict[Union[bool, None, Literal['const', 'invalidates']], str] = {
-            True: 'DbusPropertyEmitsChangeFlag',
-            'invalidates': 'DbusPropertyEmitsInvalidationFlag',
-            'const': 'DbusPropertyConstFlag',
-        }
+    _EMITS_CHANGED_MAP: Dict[
+        Union[bool, Literal['const', 'invalidates']], str
+    ] = {
+        True: 'DbusPropertyEmitsChangeFlag',
+        'invalidates': 'DbusPropertyEmitsInvalidationFlag',
+        'const': 'DbusPropertyConstFlag',
+    }
 
     def __init__(self, element: Element):
         if element.tag != 'property':
             raise ValueError(f"Expected property tag, got {element.tag}")
 
         self.dbus_signature = element.attrib['type']
 
-        self.emits_changed: \
-            Union[bool, Literal['const', 'invalidates'], None] = None
+        self.emits_changed: Union[bool, Literal['const', 'invalidates']] = True
         self.is_explicit = False
 
         access_type = element.attrib['access']
diff --git a/test/test_interface_generator.py b/test/test_interface_generator.py
@@ -183,7 +183,7 @@ def test_parsing(self) -> None:
                 elif test_property.method_name == 'Bar':
                     self.assertEqual(
                         test_property.emits_changed,
-                        None,
+                        True,
                     )
                 elif test_property.method_name == 'FooInvalidates':
                     self.assertEqual(

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ def test_parsing(self) -> None:`
`183`	`183`	`elif test_property.method_name == 'Bar':`
`184`	`184`	`self.assertEqual(`
`185`	`185`	`test_property.emits_changed,`
`186`		`- None,`
	`186`	`+ True,`
`187`	`187`	`)`
`188`	`188`	`elif test_property.method_name == 'FooInvalidates':`
`189`	`189`	`self.assertEqual(`