Skip to content

add Sanitize command to sbc opcodes#147

Merged
rosjat merged 3 commits into
python-scsi:masterfrom
jackeichen:master
May 6, 2026
Merged

add Sanitize command to sbc opcodes#147
rosjat merged 3 commits into
python-scsi:masterfrom
jackeichen:master

Conversation

@jackeichen

Copy link
Copy Markdown
Contributor

add Sanitize command to sbc opcodes

add Sanitize command to sbc opcodes

@rosjat rosjat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the opcode that seems to be ok but please put it in the right spot in the list. it should be between REQUEST_SENSE and SECURITY_PROTOCOL_IN to stay consitent.

@rosjat rosjat requested a review from sahlberg April 22, 2026 14:00
@rosjat

rosjat commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

in general try to run the pre-commit hooks on your local machine before commiting and opening an pr

@jackeichen

jackeichen commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

Oh, fail again. I will try to run the pre-commit hooks before my next pull, please wait!

@jackeichen jackeichen requested a review from rosjat April 24, 2026 03:48
@jackeichen

Copy link
Copy Markdown
Contributor Author

It should be OK now.

@rosjat

rosjat commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

the reuse tool should befixed with the PR #148

@sahlberg

sahlberg commented May 6, 2026

Copy link
Copy Markdown
Contributor

LGTM
@jackeichen When you do updates and small fixes to a commit in a PR,
don't add the changes as separate commits. Instead amend the commit and then force-push an updated PR.

But it is fine here, can just use "squash" when merging the PR so the 3 commits will all be squashed into one.

@jackeichen

Copy link
Copy Markdown
Contributor Author

LGTM @jackeichen When you do updates and small fixes to a commit in a PR, don't add the changes as separate commits. Instead amend the commit and then force-push an updated PR.

But it is fine here, can just use "squash" when merging the PR so the 3 commits will all be squashed into one.

@rosjat @sahlberg Thank you so much for the review and clear guidance! I've fully got it, and will strictly follow the workflow for all updates and fixes in my future PRs. Really appreciate your help with this.

@rosjat rosjat removed the request for review from sahlberg May 6, 2026 19:06
@rosjat rosjat merged commit 2f2ea8e into python-scsi:master May 6, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants