Skip to content

Add support for osprey_floodlight (Floodlight Cam 2K) (#558) - #567

Open
PCTEJA wants to merge 1 commit into
python-ring-doorbell:masterfrom
PCTEJA:add-osprey-floodlight-558
Open

PCTEJA wants to merge 1 commit into
python-ring-doorbell:masterfrom
PCTEJA:add-osprey-floodlight-558

Conversation

@PCTEJA

@PCTEJA PCTEJA commented Nov 15, 2026

Copy link
Copy Markdown

Add support for osprey_floodlight (Floodlight Cam 2K)

Fixes #558.

Problem

A Ring Floodlight Cam 2K reports kind: osprey_floodlight, which was in none
of the library's kind lists. The library logged
ERROR [ring_doorbell.stickup_cam] Unknown kind: osprey_floodlight, and in
Home Assistant the device showed up as an "Unknown Stickup Cam" with camera
and motion only — no light or siren entities — even though the device reports
led_status, health.floodlight_on / health.siren_on, and
settings.floodlight_settings (brightness: 10, duration: 60,
always_on: false). Related Home Assistant issue:
home-assistant/core#184792.

Fix

  • New list in ring_doorbell/const.py:
    FLOODLIGHT_CAM_2K_KINDS = ["osprey_floodlight"].
  • RingStickUpCam.model in ring_doorbell/stickup_cam.py returns
    "Floodlight Cam 2K" for that list, and the list is added to the existing
    LIGHT, SIREN, and MOTION_DETECTION/VIDEO has_capability unions alongside
    the other floodlight lists. No new device class is needed — RingStickUpCam
    already handles floodlights, and the light/siren control endpoints are
    constructed generically from the device id.
  • Battery capability is intentionally not granted: the reporter's device
    is wired (settings.power_mode: "wired", battery_life: null).

Model-name choice — please confirm

The issue title calls this device "Floodlight Cam 2K", while the body
speculates it might be "Ring Floodlight Cam 4K Pro?". I went with
"Floodlight Cam 2K" because:

  • the title is the reporter's own wording for the device;
  • the "4K Pro" guess is explicitly speculative (with a ?) and nothing in
    the attached device JSON supports 4K or Pro — firmware cam-1.5.13222
    and the floodlight settings match an ordinary floodlight;
  • it mirrors the repo's precedent of one list per floodlight generation
    (cocoa_floodlight → "Floodlight Cam Plus", floodlight_pro →
    "Floodlight Cam Pro") rather than folding a distinct device into the
    plain "Floodlight Cam" list (hp_cam_v1, floodlight_v2).

If Ring's official name for this hardware is different, I am happy to rename
the list/model — the capability fix itself does not depend on the name.

Tests

  • New fixture device in tests/fixtures/ring_devices.json (id 987654,
    osprey_floodlight, fields taken from the reporter's attached device JSON:
    wired, firmware cam-1.5.13222, floodlight settings duration 60 /
    brightness 10 / always_on false, led_status: "off",
    siren_status: {seconds_remaining: 0}).
  • New test_osprey_floodlight_attributes in tests/test_ring.py asserts
    model "Floodlight Cam 2K" and light/siren/motion/video/history True,
    battery False, lights "off", siren 0.
  • Before the fix the new test fails:
    assert 'Unknown Stickup Cam' == 'Floodlight Cam 2K', with the
    Unknown kind: osprey_floodlight error logged. After the fix it passes.
  • Full suite: 41 passed. The new fixture device also appears in the CLI
    device list, so test_list's expected output was updated accordingly.
  • ruff check and ruff format --check are clean on the changed files;
    mypy over ring_doorbell reports no issues. (Repo-wide ruff check
    still shows the same 2 pre-existing findings in untouched files,
    ring_doorbell/__init__.py RUF022 and ring_doorbell/auth.py A004.)

Edge cases

AI assistance

This contribution was drafted with AI assistance (code review by an
independent AI reviewer against the exact commit, and the fix/test code
written with AI tooling). The evidence — the reporter's device JSON fields,
the before/after test runs, and the full test suite — was verified locally,
and the model-name decision above is flagged for maintainer confirmation.

…l#558)

Devices reporting kind osprey_floodlight logged 'Unknown kind:
osprey_floodlight' and showed up as 'Unknown Stickup Cam' with no
light or siren entities, even though the device reports led_status,
health.floodlight_on/siren_on and settings.floodlight_settings
(brightness/duration/always_on). Add the kind to a new
FLOODLIGHT_CAM_2K_KINDS list so RingStickUpCam reports model
'Floodlight Cam 2K' and grants light, siren, motion and video
capabilities via the existing floodlight branches.

Model name follows the issue title ('Floodlight Cam 2K'); the body's
'Ring Floodlight Cam 4K Pro?' guess is unconfirmed, so the maintainer
may rename. Mirrors the cocoa_floodlight -> Floodlight Cam Plus
precedent of one list per floodlight generation.

Add an osprey_floodlight fixture device (fields from the reporter's
attached device JSON: wired, firmware cam-1.5.13222, floodlight
settings duration 60 / brightness 10 / always_on false) and a
regression test asserting model and capabilities.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding support for osprey_floodlight (Floodlight Cam 2K)

1 participant