Repository navigation
Keep alert capabilities for unmapped doorbell kinds - #562
Closed
trulyshelton wants to merge 1 commit into
Closed
trulyshelton wants to merge 1 commit into
trulyshelton wants to merge 1 commit into
Conversation
Ring ships new doorbell models far faster than the kind mapping is updated, so a brand new doorbell - or any model that was never added here - falls through to Unknown Doorbell. For such a kind, has_capability() returns False for DING, MOTION_DETECTION and VIDEO. Consumers use those capabilities to decide whether a device can produce alerts at all: Home Assistant only creates the ding/motion event entities when they are set, and it only starts the Ring event listener when those entities register with the listen coordinator. An unmapped doorbell therefore goes silent - no ring/motion events, and every new recording is only picked up by the one minute polling fallback instead of the realtime push, which adds around a minute to every notification. Everything in the doorbots and authorized_doorbots families is a doorbell, so assume the standard alerts for an unmapped kind instead of dropping them, and log the kind once so it can be reported and mapped properly. Battery and knock stay hardware/settings dependent and are unchanged. Refs #521, #543
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kindnow keepsDING,MOTION_DETECTIONandVIDEOcapabilities instead of silently reportingFalsefor all three.Why
Ring releases new doorbell models faster than this mapping is updated. Until a kind is added,
RingDoorBell.modelfalls through toUnknown Doorbellandhas_capability()returnsFalsefor ding/motion/video, which is destructive rather than merely cosmetic:event.<doorbell>_ding/event.<doorbell>_motionentities when those capabilities are present (components/ring/event.py).RingListenCoordinator, and the coordinator only startsRingEventListener(the FCM push connection) when it gets its first listener (components/ring/coordinator.py).So an unrecognised doorbell does not just lose its model name, it loses realtime events entirely and every recording is only picked up by the one minute polling fallback (
SCAN_INTERVAL = timedelta(minutes=1)), which cannot be tuned from the UI.Measured on a real unmapped device (
kind=cocoa_doorbell_v4w, Ring Wired Video Doorbell Plus 2nd Gen, firmware cam-1.33.12300) running Home Assistant 2026.10.4 / ring-doorbell 0.9.14, using the recorder over 11 days and 120 events: median 62s from the Ring eventcreated_atto the Home Assistant state write, p90 90s, of which normally ~1s is the notification dispatch itself. The device appears in the registry asUnknown Doorbellwith no ding/motion entities.Everything in
doorbotsandauthorized_doorbotsis a doorbell, so assuming the standard alerts is safe: if a device turns out not to emit dings, the entity simply never fires. Being able to receive a doorbell press at all is worth more than being strict about an unmapped model.Testing
New tests cover an unmapped kind reporting the standard capabilities, and the warning being emitted once rather than on every property access.
Notes
This deliberately does not add a kind mapping, so the model name stays
Unknown Doorbellfor these devices - #539 already addscocoa_doorbell_v4wasDOORBELL_WIRED_PLUS_2_KINDSand can land (or not) independently. This change means users are not left with a dead doorbell while that happens, and the warning tells them exactly which kind to report.Refs #521, #543