Repository navigation
Add support for newer Ring device kinds (Doorbell Pro 4K, Elite cameras, Spotlight Cam 4K Pro, Chime 2nd Gen) - #553
Open
tomroberts78 wants to merge 1 commit into
Conversation
… Spotlight 4K Pro, Chime 2nd Gen)
This was referenced Sep 15, 2026
|
I opened #556 to also fix modern FCM events that omit |
This was referenced Sep 15, 2026
2 of 3 tasks
AMoo-Miki
added a commit
to AMoo-Miki/python-ring-cameras
that referenced
this pull request
Oct 9, 2026
Upstream python-ring-doorbell has had no merges for months; this takes what its open pull requests offer, adapted to this fork: - WebRTC: _close() no longer awaits its own reader task when the stream closes from inside it (upstream python-ring-doorbell#548, python-ring-doorbell#534). - New RingDoorBell.async_take_snapshot(): one request that returns a stored snapshot newer than max_age or captures a fresh one, via the endpoint ring-mqtt uses (upstream python-ring-doorbell#528). Existing snapshot methods are unchanged. - Outdoor Cam Plus reports a battery from its health data when it says either way, so plug-in variants no longer get one; a camera whose battery died reports nothing and keeps it (upstream python-ring-doorbell#538, reworked). - Device kinds: Battery Doorbell Pro 4K, Wired Doorbell Plus (2nd Gen), Wired Doorbell (doorbell_tahoe), Doorbell (2nd Gen) cocoa_doorbell_v3, Indoor Cam Plus, Spotlight Cam Pro 4K, Elite Cam 140/360 4K and Chime (2nd Gen) (upstream python-ring-doorbell#553, python-ring-doorbell#539, python-ring-doorbell#536, python-ring-doorbell#531, python-ring-doorbell#550). Co-authored-by: Niels Haagsman <haagsman@gmail.com> Co-authored-by: Adam Reeve <adam@adamreeve.com> Co-authored-by: danielcolquitt <daniel@colquitt.xyz> Co-authored-by: Tom Roberts <tom@tomroberts.co.uk> Co-authored-by: ben79 <benjaminfearnley@gmail.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: Yoan <yoan.cousin@proton.me>
AMoo-Miki
added a commit
to AMoo-Miki/python-ring-cameras
that referenced
this pull request
Oct 9, 2026
Upstream python-ring-doorbell has had no merges for months; this takes what its open pull requests offer, adapted to this fork: - WebRTC: _close() no longer awaits its own reader task when the stream closes from inside it (upstream python-ring-doorbell#548, python-ring-doorbell#534). - New RingDoorBell.async_take_snapshot(): one request that returns a stored snapshot newer than max_age or captures a fresh one, via the endpoint ring-mqtt uses (upstream python-ring-doorbell#528). Existing snapshot methods are unchanged. - Outdoor Cam Plus reports a battery from its health data when it says either way, so plug-in variants no longer get one; a camera whose battery died reports nothing and keeps it (upstream python-ring-doorbell#538, reworked). - Device kinds: Battery Doorbell Pro 4K, Wired Doorbell Plus (2nd Gen), Wired Doorbell (doorbell_tahoe), Doorbell (2nd Gen) cocoa_doorbell_v3, Indoor Cam Plus, Spotlight Cam Pro 4K, Elite Cam 140/360 4K and Chime (2nd Gen) (upstream python-ring-doorbell#553, python-ring-doorbell#539, python-ring-doorbell#536, python-ring-doorbell#531, python-ring-doorbell#550). Co-authored-by: Niels Haagsman <haagsman@gmail.com> Co-authored-by: Adam Reeve <adam@adamreeve.com> Co-authored-by: danielcolquitt <daniel@colquitt.xyz> Co-authored-by: Tom Roberts <tom@tomroberts.co.uk> Co-authored-by: ben79 <benjaminfearnley@gmail.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: Yoan <yoan.cousin@proton.me>
AMoo-Miki
added a commit
to AMoo-Miki/python-ring-cameras
that referenced
this pull request
Oct 16, 2026
Upstream python-ring-doorbell has had no merges for months; this takes what its open pull requests offer, adapted to this fork: - WebRTC: _close() no longer awaits its own reader task when the stream closes from inside it (upstream python-ring-doorbell#548, python-ring-doorbell#534). - New RingDoorBell.async_take_snapshot(): one request that returns a stored snapshot newer than max_age or captures a fresh one, via the endpoint ring-mqtt uses (upstream python-ring-doorbell#528). Existing snapshot methods are unchanged. - Outdoor Cam Plus reports a battery from its health data when it says either way, so plug-in variants no longer get one; a camera whose battery died reports nothing and keeps it (upstream python-ring-doorbell#538, reworked). - Device kinds: Battery Doorbell Pro 4K, Wired Doorbell Plus (2nd Gen), Wired Doorbell (doorbell_tahoe), Doorbell (2nd Gen) cocoa_doorbell_v3, Indoor Cam Plus, Spotlight Cam Pro 4K, Elite Cam 140/360 4K and Chime (2nd Gen) (upstream python-ring-doorbell#553, python-ring-doorbell#539, python-ring-doorbell#536, python-ring-doorbell#531, python-ring-doorbell#550). Co-authored-by: Niels Haagsman <haagsman@gmail.com> Co-authored-by: Adam Reeve <adam@adamreeve.com> Co-authored-by: danielcolquitt <daniel@colquitt.xyz> Co-authored-by: Tom Roberts <tom@tomroberts.co.uk> Co-authored-by: ben79 <benjaminfearnley@gmail.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: Yoan <yoan.cousin@proton.me>
AMoo-Miki
added a commit
to AMoo-Miki/python-ring-cameras
that referenced
this pull request
Oct 16, 2026
Upstream python-ring-doorbell has had no merges for months; this takes what its open pull requests offer, adapted to this fork: - WebRTC: _close() no longer awaits its own reader task when the stream closes from inside it (upstream python-ring-doorbell#548, python-ring-doorbell#534). - New RingDoorBell.async_take_snapshot(): one request that returns a stored snapshot newer than max_age or captures a fresh one, via the endpoint ring-mqtt uses (upstream python-ring-doorbell#528). Existing snapshot methods are unchanged. - Outdoor Cam Plus reports a battery from its health data when it says either way, so plug-in variants no longer get one; a camera whose battery died reports nothing and keeps it (upstream python-ring-doorbell#538, reworked). - Device kinds: Battery Doorbell Pro 4K, Wired Doorbell Plus (2nd Gen), Wired Doorbell (doorbell_tahoe), Doorbell (2nd Gen) cocoa_doorbell_v3, Indoor Cam Plus, Spotlight Cam Pro 4K, Elite Cam 140/360 4K and Chime (2nd Gen) (upstream python-ring-doorbell#553, python-ring-doorbell#539, python-ring-doorbell#536, python-ring-doorbell#531, python-ring-doorbell#550). Co-authored-by: Niels Haagsman <haagsman@gmail.com> Co-authored-by: Adam Reeve <adam@adamreeve.com> Co-authored-by: danielcolquitt <daniel@colquitt.xyz> Co-authored-by: Tom Roberts <tom@tomroberts.co.uk> Co-authored-by: ben79 <benjaminfearnley@gmail.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: Yoan <yoan.cousin@proton.me>
AMoo-Miki
added a commit
to AMoo-Miki/python-ring-cameras
that referenced
this pull request
Oct 16, 2026
Upstream python-ring-doorbell has had no merges for months; this takes what its open pull requests offer, adapted to this fork: - WebRTC: _close() no longer awaits its own reader task when the stream closes from inside it (upstream python-ring-doorbell#548, python-ring-doorbell#534). - New RingDoorBell.async_take_snapshot(): one request that returns a stored snapshot newer than max_age or captures a fresh one, via the endpoint ring-mqtt uses (upstream python-ring-doorbell#528). Existing snapshot methods are unchanged. - Outdoor Cam Plus reports a battery from its health data when it says either way, so plug-in variants no longer get one; a camera whose battery died reports nothing and keeps it (upstream python-ring-doorbell#538, reworked). - Device kinds: Battery Doorbell Pro 4K, Wired Doorbell Plus (2nd Gen), Wired Doorbell (doorbell_tahoe), Doorbell (2nd Gen) cocoa_doorbell_v3, Indoor Cam Plus, Spotlight Cam Pro 4K, Elite Cam 140/360 4K and Chime (2nd Gen) (upstream python-ring-doorbell#553, python-ring-doorbell#539, python-ring-doorbell#536, python-ring-doorbell#531, python-ring-doorbell#550). Co-authored-by: Niels Haagsman <haagsman@gmail.com> Co-authored-by: Adam Reeve <adam@adamreeve.com> Co-authored-by: danielcolquitt <daniel@colquitt.xyz> Co-authored-by: Tom Roberts <tom@tomroberts.co.uk> Co-authored-by: ben79 <benjaminfearnley@gmail.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: Yoan <yoan.cousin@proton.me>
|
My Ring Chime (2nd Gen) reports kind: chime_v3, so it still shows up as "Unknown Chime" (ring-doorbell 0.9.14). Could you add chime_v3 to CHIME_KINDS alongside chime_v4? Same account also has a Battery Doorbell Pro with cocoa_doorbell_v3 (covered by #550). Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for six newer Ring device
kinds that currently register as "Unknown Doorbell"/"Unknown Stickup Cam"/"Unknown Chime". Unmapped kinds fall throughhas_capability()and lose motion/siren/ding entities, so these are more than cosmetic naming fixes.cocoa_doorbell_v5cocoa_doorbell_v6cocoa_spotlight_v2hexa_camera_2_v1hexa_camera_6_v1chime_v4Capabilities wired up
cocoa_doorbell_v6getsBATTERY; both getVIDEO/MOTION_DETECTION/DING.LIGHT,SIREN,VIDEO,MOTION_DETECTION(no battery — PoE/wired).SIREN,VIDEO,MOTION_DETECTION(no battery — PoE/wired).VOLUMEvia the generic chime path.Testing
Unknown kind:.python -m py_compileclean on all touched files.Related
cocoa_doorbell_v5— registers as "Unknown Doorbell" with no ding or motion entities #544 (cocoa_doorbell_v5) — this PR adds the mapping that issue asked for.cocoa_camera_v2/v3,cocoa_floodlight_v2orstickup_cam_mini_v3— those are already covered by open PRs Recognize cocoa_camera_v3, cocoa_floodlight_v2 and stickup_cam_mini_v3 kinds #529, Add support for Ring Indoor Cam Plus (stickup_cam_mini_v3) #531 and Add device kinds cocoa_camera_v2, cocoa_camera_v3 and cocoa_doorbell_v3 #550.