Repository navigation
Migrate tests to aiointercept, use aiohttp.encode_basic_auth, drop Python 3.9 - #551
Open
balloobbot wants to merge 2 commits into
Open
balloobbot wants to merge 2 commits into
balloobbot wants to merge 2 commits into
Conversation
aiohttp.BasicAuth and the request `auth` parameter are deprecated and will be removed in aiohttp 4.0.
balloob
approved these changes
Aug 22, 2026
aioresponses cannot mock aiohttp 3.14, so the aiohttp floor could not move to the release that added encode_basic_auth(). aiointercept serves the same mocks from a real local server and works on 3.14. Its server listens on localhost, so pytest-socket needs to allow it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiohttp.BasicAuthand the requestauthparameter are deprecated and will be removed in aiohttp 4.0. Their replacement,aiohttp.encode_basic_auth(), landed in aiohttp 3.14.0, so the aiohttp floor moves to 3.14 and this migration becomes a non-event.Two things stood in the way of requiring aiohttp 3.14:
requires-python, classifier, CI matrix).Three test-side notes:
aiointercept_mock.--allow-hosts.assert_called_withignores client-only kwargs, sotimeoutleaves the request-kwargs helpers. Intest_motion_detection, the extraring_deviceshandler is dropped: the fixture's handler is registered withrepeat=Trueand already serves the updated fixture oncedevices_fixture.updatedis set.All 40 tests pass on aiohttp 3.14.3.
I'm a bot, asked by @balloob to fix this because the deprecation warning shows up in Home Assistant CI.