Repository navigation
Add Outdoor Cam Plus stickup cam mapping - #538
danielcolquitt wants to merge 1 commit into
Conversation
Upstream python-ring-doorbell has had no merges for months; this takes what its open pull requests offer, adapted to this fork: - WebRTC: _close() no longer awaits its own reader task when the stream closes from inside it (upstream python-ring-doorbell#548, python-ring-doorbell#534). - New RingDoorBell.async_take_snapshot(): one request that returns a stored snapshot newer than max_age or captures a fresh one, via the endpoint ring-mqtt uses (upstream python-ring-doorbell#528). Existing snapshot methods are unchanged. - Outdoor Cam Plus reports a battery from its health data when it says either way, so plug-in variants no longer get one; a camera whose battery died reports nothing and keeps it (upstream python-ring-doorbell#538, reworked). - Device kinds: Battery Doorbell Pro 4K, Wired Doorbell Plus (2nd Gen), Wired Doorbell (doorbell_tahoe), Doorbell (2nd Gen) cocoa_doorbell_v3, Indoor Cam Plus, Spotlight Cam Pro 4K, Elite Cam 140/360 4K and Chime (2nd Gen) (upstream python-ring-doorbell#553, python-ring-doorbell#539, python-ring-doorbell#536, python-ring-doorbell#531, python-ring-doorbell#550). Co-authored-by: Niels Haagsman <haagsman@gmail.com> Co-authored-by: Adam Reeve <adam@adamreeve.com> Co-authored-by: danielcolquitt <daniel@colquitt.xyz> Co-authored-by: Tom Roberts <tom@tomroberts.co.uk> Co-authored-by: ben79 <benjaminfearnley@gmail.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: Yoan <yoan.cousin@proton.me>
Upstream python-ring-doorbell has had no merges for months; this takes what its open pull requests offer, adapted to this fork: - WebRTC: _close() no longer awaits its own reader task when the stream closes from inside it (upstream python-ring-doorbell#548, python-ring-doorbell#534). - New RingDoorBell.async_take_snapshot(): one request that returns a stored snapshot newer than max_age or captures a fresh one, via the endpoint ring-mqtt uses (upstream python-ring-doorbell#528). Existing snapshot methods are unchanged. - Outdoor Cam Plus reports a battery from its health data when it says either way, so plug-in variants no longer get one; a camera whose battery died reports nothing and keeps it (upstream python-ring-doorbell#538, reworked). - Device kinds: Battery Doorbell Pro 4K, Wired Doorbell Plus (2nd Gen), Wired Doorbell (doorbell_tahoe), Doorbell (2nd Gen) cocoa_doorbell_v3, Indoor Cam Plus, Spotlight Cam Pro 4K, Elite Cam 140/360 4K and Chime (2nd Gen) (upstream python-ring-doorbell#553, python-ring-doorbell#539, python-ring-doorbell#536, python-ring-doorbell#531, python-ring-doorbell#550). Co-authored-by: Niels Haagsman <haagsman@gmail.com> Co-authored-by: Adam Reeve <adam@adamreeve.com> Co-authored-by: danielcolquitt <daniel@colquitt.xyz> Co-authored-by: Tom Roberts <tom@tomroberts.co.uk> Co-authored-by: ben79 <benjaminfearnley@gmail.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: Yoan <yoan.cousin@proton.me>
|
My Ring Outdoor Cam Plus is not recognized by the library. In Home Assistant Because of this, only basic entities are created (live view, last recording, Expected: Outdoor Cam Plus is recognized as a supported model and gets the same Diagnostics of the device are attached (sensitive data redacted by HA). Device: Ring Outdoor Cam Plus (battery) |
Upstream python-ring-doorbell has had no merges for months; this takes what its open pull requests offer, adapted to this fork: - WebRTC: _close() no longer awaits its own reader task when the stream closes from inside it (upstream python-ring-doorbell#548, python-ring-doorbell#534). - New RingDoorBell.async_take_snapshot(): one request that returns a stored snapshot newer than max_age or captures a fresh one, via the endpoint ring-mqtt uses (upstream python-ring-doorbell#528). Existing snapshot methods are unchanged. - Outdoor Cam Plus reports a battery from its health data when it says either way, so plug-in variants no longer get one; a camera whose battery died reports nothing and keeps it (upstream python-ring-doorbell#538, reworked). - Device kinds: Battery Doorbell Pro 4K, Wired Doorbell Plus (2nd Gen), Wired Doorbell (doorbell_tahoe), Doorbell (2nd Gen) cocoa_doorbell_v3, Indoor Cam Plus, Spotlight Cam Pro 4K, Elite Cam 140/360 4K and Chime (2nd Gen) (upstream python-ring-doorbell#553, python-ring-doorbell#539, python-ring-doorbell#536, python-ring-doorbell#531, python-ring-doorbell#550). Co-authored-by: Niels Haagsman <haagsman@gmail.com> Co-authored-by: Adam Reeve <adam@adamreeve.com> Co-authored-by: danielcolquitt <daniel@colquitt.xyz> Co-authored-by: Tom Roberts <tom@tomroberts.co.uk> Co-authored-by: ben79 <benjaminfearnley@gmail.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: Yoan <yoan.cousin@proton.me>
Upstream python-ring-doorbell has had no merges for months; this takes what its open pull requests offer, adapted to this fork: - WebRTC: _close() no longer awaits its own reader task when the stream closes from inside it (upstream python-ring-doorbell#548, python-ring-doorbell#534). - New RingDoorBell.async_take_snapshot(): one request that returns a stored snapshot newer than max_age or captures a fresh one, via the endpoint ring-mqtt uses (upstream python-ring-doorbell#528). Existing snapshot methods are unchanged. - Outdoor Cam Plus reports a battery from its health data when it says either way, so plug-in variants no longer get one; a camera whose battery died reports nothing and keeps it (upstream python-ring-doorbell#538, reworked). - Device kinds: Battery Doorbell Pro 4K, Wired Doorbell Plus (2nd Gen), Wired Doorbell (doorbell_tahoe), Doorbell (2nd Gen) cocoa_doorbell_v3, Indoor Cam Plus, Spotlight Cam Pro 4K, Elite Cam 140/360 4K and Chime (2nd Gen) (upstream python-ring-doorbell#553, python-ring-doorbell#539, python-ring-doorbell#536, python-ring-doorbell#531, python-ring-doorbell#550). Co-authored-by: Niels Haagsman <haagsman@gmail.com> Co-authored-by: Adam Reeve <adam@adamreeve.com> Co-authored-by: danielcolquitt <daniel@colquitt.xyz> Co-authored-by: Tom Roberts <tom@tomroberts.co.uk> Co-authored-by: ben79 <benjaminfearnley@gmail.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: Yoan <yoan.cousin@proton.me>
Upstream python-ring-doorbell has had no merges for months; this takes what its open pull requests offer, adapted to this fork: - WebRTC: _close() no longer awaits its own reader task when the stream closes from inside it (upstream python-ring-doorbell#548, python-ring-doorbell#534). - New RingDoorBell.async_take_snapshot(): one request that returns a stored snapshot newer than max_age or captures a fresh one, via the endpoint ring-mqtt uses (upstream python-ring-doorbell#528). Existing snapshot methods are unchanged. - Outdoor Cam Plus reports a battery from its health data when it says either way, so plug-in variants no longer get one; a camera whose battery died reports nothing and keeps it (upstream python-ring-doorbell#538, reworked). - Device kinds: Battery Doorbell Pro 4K, Wired Doorbell Plus (2nd Gen), Wired Doorbell (doorbell_tahoe), Doorbell (2nd Gen) cocoa_doorbell_v3, Indoor Cam Plus, Spotlight Cam Pro 4K, Elite Cam 140/360 4K and Chime (2nd Gen) (upstream python-ring-doorbell#553, python-ring-doorbell#539, python-ring-doorbell#536, python-ring-doorbell#531, python-ring-doorbell#550). Co-authored-by: Niels Haagsman <haagsman@gmail.com> Co-authored-by: Adam Reeve <adam@adamreeve.com> Co-authored-by: danielcolquitt <daniel@colquitt.xyz> Co-authored-by: Tom Roberts <tom@tomroberts.co.uk> Co-authored-by: ben79 <benjaminfearnley@gmail.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: Yoan <yoan.cousin@proton.me>
Summary
Ring reports Outdoor Cam Plus devices using the previously unknown
cocoa_camera_v2kind.cocoa_camera_v2devices to the Outdoor Cam Plus model.health.battery_present, falling back tobattery_lifewhen needed.Testing
uv run pre-commit run --all-files --verboseuv run pytest tests/ --force-enable-socket --cov=ring_doorbell --cov-report=xml --cov-report=term-missing --import-mode importlibuv run docs\make.bat html