Skip to content

Fix "Task cannot await on itself" when close() runs inside the reader task #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nielsh82 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix "Task cannot await on itself" when close() runs inside the reader task #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ring_doorbell/webrtcstream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ async def _close(self, *, closed_by_self: bool) -> None:
await websocket.close()
if read_task := self.read_task:
self.read_task = None
if not read_task.done():
if not read_task.done() and read_task is not asyncio.current_task():
await read_task

async def handle_message(self, message_str: str) -> None: # noqa: C901, PLR0912
Expand Down