Update the snapshot download method to use more reliable endpoint#528
Open
reeve wants to merge 1 commit into
Open
Update the snapshot download method to use more reliable endpoint#528reeve wants to merge 1 commit into
reeve wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #527
This PR replaces the implementation of
async_get_snapshotwith a call to the same snapshot endpoint used by ring-mqtt. This endpoint essentially does a search query, you can pass in a "must be after" timestamp, and if an image already exists that is younger than that it will be returned. Otherwise, if theforceflag is set, a new image will be generated on the fly and returned, provided the timeout doesn't elapse. This removes the need to make multiple API calls, and the fail/retry logic of the old method.I wasn't sure how you like to handle API changes (as the parameters are quite different given this code works differently) - I elected to mark the old one deprecated and create a whole new method. But if you prefer to just replace the old one with the same name and flag a breaking change in the release notes I'm happy to make that update. I also added some basic tests.
LMK if you have questions/comments :)