subclassing Quantity #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddale
added a commit
that referenced
this pull request
Dec 16, 2011
allows Quantity to be subclassed
Member
|
Please run the unit tests before filing a merge request. Three tests fail with these changes. |
Author
|
Sorry for that. Tests did not fail on my computer. But I am not sure how you test. I assumed from your test-structure that you use |
Author
|
As an alternative to subclassing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everybody,
I use Quantity to develop a toolkit for neuroscientists. For my work it is important to be able to subclass Quantity. Methods of these subclasses should return again instances of this subclass. Therefore I change in
quantity.py:return Quantity--->return self.__class__To test return types I added also
test_inheritance.pyCheers,
Philipp