Switch np aliases which will be removed in NumPy 2.0
#227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thanks for this @zm711 I would be reluctant to add scipy as a dependency, since it's not exactly lightweight; rather, I think we should copy the implementation of |
Contributor
Author
|
I can give a stab at making trapz in quantities, but let me look at the source code to see how involved it will be. The one failing test seems to be a build error with Cython (old numpy and old python), but doesn't seem to be anything I did. Could you rerun the tests once to see if it repeats (or take a look and see if you understand the error better than I do?) |
Contributor
Author
|
I was able to find that there is a build issue with cython and numpy 1.19.0 that can occur in building. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
np.trapzwill be deprecated, and the recommendation is to switch to using a scipy function instead. I can delete trapz in this PR if you want or just leave it alone until it becomes a hard error.