Skip to content

Add type checking with mypy to CI #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apdavison merged 2 commits into from
Dec 8, 2023
Merged

Add type checking with mypy to CI #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a1cfb3
Add type checking with mypy to CI
apdavison Apr 5, 2023
b470064
Don't run static type checks with older versions of NumPy
apdavison Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,48 @@ jobs:
run: |
PY_IGNORE_IMPORTMISMATCH=1 pytest
python -m doctest README.rst

type-check:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ ubuntu-latest ]
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
numpy-version: [ "1.22", "1.23", "1.24" ]
steps:
- uses: actions/checkout@v2

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}

- name: Get pip cache dir
id: pip-cache
run: |
echo "::set-output name=dir::$(pip cache dir)"

- name: Cache
uses: actions/cache@v2
with:
path: ${{ steps.pip-cache.outputs.dir }}
key:
${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.numpy-version }}-v1-${{ hashFiles('**/setup.py') }}
restore-keys: |
${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.numpy-version }}-v1-

- name: Install dependencies
run: |
python -m pip install -U pip
python -m pip install -U wheel
python -m pip install "numpy==${{ matrix.numpy-version }}"
python -m pip install -U mypy

- name: Install
run: |
pip install .

- name: Check type information
run: |
mypy quantities