Skip to content

Fix more backslash escapes#193

Closed
larsoner wants to merge 2 commits intopython-quantities:masterfrom
larsoner:escape
Closed

Fix more backslash escapes#193
larsoner wants to merge 2 commits intopython-quantities:masterfrom
larsoner:escape

Conversation

@larsoner
Copy link
Copy Markdown

Follow-up to #189

@apdavison
Copy link
Copy Markdown
Contributor

I think these changes have now been added in other PRs.

Replace the units string provided with an equivalent latex string.

Division (a/b) will be replaced by \frac{a}{b}.
Division (a/b) will be replaced by \\frac{a}{b}.
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not been fixed yet

Division (a/b) will be replaced by \frac{a}{b}.

options may be '' or '*'.

If paren=True, encapsulate the string in '\\left(' and '\right)'
If paren=True, encapsulate the string in '\\left(' and '\\right)'
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one of the two errors on this line had been fixed

If paren=True, encapsulate the string in '\\left(' and '\right)'

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... but it does look like this one is actually fixed by #196

@larsoner
Copy link
Copy Markdown
Author

I think these changes have now been added in other PRs.

Ahh I see you mean pending PRs, I was looking at latest master. Closing!

@larsoner larsoner closed this Oct 18, 2021
@apdavison
Copy link
Copy Markdown
Contributor

Ahh I see you mean pending PRs, I was looking at latest master. Closing!

yes, sorry for not being clear! Many thanks for taking the time to check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants