rescale stopped working for rad and deg #215

Activity

1. apdavison commented on Feb 16, 2023

   

   apdavison

   on Feb 16, 2023

   Contributor

   More actions

   Thanks for reporting this. We'll look into it urgently.

   As a workaround, I note that explicitly giving heading a float dtype avoids the problem, e.g.

   heading = pq.Quantity(10.0, pq.deg)
   print(heading.rescale(pq.rad)) -> array(0.17453293) * rad
   
2. apdavison commented on Feb 16, 2023

   

   apdavison

   on Feb 16, 2023

   Contributor

   More actions

   @bjodah could you look at this?
3. bjodah commented on Feb 17, 2023

   

   bjodah

   on Feb 17, 2023

   Contributor

   More actions

   @apdavison, sure I'll look into this right away, I think I see what's happening here: numpy casting rules aren't really well suited for integer types in quantities. I'll try to put a PR together.
4. bjodah

   added a commit that references this issue on Feb 17, 2023

   Fix python-quantitiesgh-215, dtype conversion in rescale

   This issue will close once commit abefd96 is merged into the 'master' branch.

   abefd96
5. apdavison

   added a commit that references this issue on Feb 17, 2023

   add more unit tests, including a regression test for gh-215

   8239f66
6. apdavison

   closed this as completedin abefd96on Feb 17, 2023
7. apdavison

   added a commit that references this issue on Feb 17, 2023

   Merge pull request #216 from bjodah/fix-rescale-integer-arg

   ...

   This issue will close once commit aa45ade is merged into the 'master' branch.

   aa45ade
8. apdavison

   linked a pull request that will close this issueFix gh-215, dtype conversion in rescale #216on Feb 17, 2023
9. apdavison commented on Feb 17, 2023

   

   apdavison

   on Feb 17, 2023

   Contributor

   More actions

   Many thanks for the quick response @bjodah !

   @axelande I've made a bug-fix release. Updating to 0.14.1 should fix the problem.

   👍React with 👍1Reacted by Bjorn