Do not resize macOS retina screenshots by default#9266
Open
radarhere wants to merge 5 commits intopython-pillow:mainfrom
Open
Do not resize macOS retina screenshots by default#9266radarhere wants to merge 5 commits intopython-pillow:mainfrom
radarhere wants to merge 5 commits intopython-pillow:mainfrom
Conversation
radarhere
force-pushed
the
imagegrab_resize
branch
from
8c231e7 to
ca6c75b
Compare
radarhere
force-pushed
the
imagegrab_resize
branch
from
ca6c75b to
6d51ace
Compare
radarhere
force-pushed
the
imagegrab_resize
branch
from
eeaa8cd to
3dc1937
Compare
radarhere
force-pushed
the
imagegrab_resize
branch
from
3dc1937 to
be85a6b
Compare
radarhere
force-pushed
the
imagegrab_resize
branch
from
be85a6b to
5b1a3ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9253
On macOS retina screens,
ImageGrab.grab()will produce 2x images when not usingbbox, but 1x images when usingbbox. The issue describes this as inconsistent.Scaling bounding box images down was added in #6152 with Pillow 9.1.0, so that is relatively new. This PR stops that resizing by default. If the user wishes to resize, they must provide a keyword-only argument,
ImageGrab.grab(scale_down=True)