Skip to content

Fix handling of the fold attribute when deep copying DateTime objects#776

Merged
sdispater merged 1 commit intomasterfrom
fix/deepcopy-fold
Dec 15, 2023
Merged

Fix handling of the fold attribute when deep copying DateTime objects#776
sdispater merged 1 commit intomasterfrom
fix/deepcopy-fold

Conversation

@sdispater
Copy link
Copy Markdown
Collaborator

Fixes #767

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added the bug label Dec 15, 2023
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 15, 2023

CodSpeed Performance Report

Merging #776 will degrade performances by 19.45%

Comparing fix/deepcopy-fold (4fa9b8e) with master (1ff9a1c)

Summary

❌ 1 regressions
✅ 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master fix/deepcopy-fold Change
test_format 2.3 ms 2.8 ms -19.45%

@sdispater sdispater merged commit 0a884dd into master Dec 15, 2023
@sdispater sdispater deleted the fix/deepcopy-fold branch December 15, 2023 00:10
@sdispater sdispater mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deepcopy on DateTime produces incorrect offset in copy during dst transition

1 participant