Skip to content

Conversation

@sc68cal
Copy link
Contributor

@sc68cal sc68cal commented Dec 19, 2025

Using the CLI to set include and ignore rules overrides whatever ruff configuration settings are present in a project (pyproject.toml, ruff.toml, etc).

Most projects will choose to use those existing mechanisms to configure ruff, so having python-mode override them for settings in a user's vimrc will cause differences in ruff checks between a CLI run of ruff or a CI/CD pipeline, versus running PymodeLint.

Using the CLI to set include and ignore rules overrides whatever
ruff configuration settings are present in a project (pyproject.toml,
ruff.toml, etc).

Most projects will choose to use those existing mechanisms to configure
ruff, so having python-mode override them for settings in a user's vimrc
will cause differences in ruff checks between a CLI run of ruff or a CI/CD
pipeline, versus running PymodeLint.
@sc68cal
Copy link
Contributor Author

sc68cal commented Dec 19, 2025

This is a pretty crude PR - I stripped out a lot of functionality but it's what i'm driving daily now. I wanted to share to generate discussion.

@diraol
Copy link
Contributor

diraol commented Dec 23, 2025

Thanks for the suggestion! :)

As I've mentioned on the other PR, I totally agree with you that local configs should take full priority.
I'm just wondering if we should strip out the possibility of "global vim configs" (for ruff) or if we should work on the "which rule should be applied" side of things.

And that leads us to three options:

  1. No global configs at all
  2. Keep global configs, but only use them if there are no local configs (here we need to define what will we consider, only ruff.toml? rull.toml + pyproject.toml ?)
  3. Keep global config and merge it with the local config (giving more priority to local configs over global ones)

WDYT?

@diraol
Copy link
Contributor

diraol commented Dec 23, 2025

Ok, I've made a proposal.... take a look at this commit and let me know what you think about it :)

@sc68cal
Copy link
Contributor Author

sc68cal commented Dec 24, 2025

@diraol I like the direction that you have gone with where vim configuration is a fallback method, or possibly merging. Let me give your branch a try. Thank you for taking feedback!

@sc68cal sc68cal closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants