Conversation
f044986 to
72568d6
Compare
72568d6 to
a4731b4
Compare
|
Hey folks, I need some help here, there is an error happening on the tests but I couldn't figure out how to solve it. Any help here is very welcome! |
|
@lieryan wanna help here? |
|
I was looking into this, and I think I found the issue. On current develop, when running but using the updated version in the PR, the the format of how this options has been parsed has changed a bit, but that is not the issue. The issue is that linters list no longer have A quick fix for the test is to do something like: diff --git a/pymode/lint.py b/pymode/lint.py
index c530404..56208a6 100644
--- a/pymode/lint.py
+++ b/pymode/lint.py
@@ -42,6 +42,10 @@ def code_check():
raise ValueError('g:pymode_lint_select should have a list type')
else:
select = env.var('g:pymode_lint_select')
+ if 'pep8' in linters:
+ ## maybe add user-visible deprecation warning here
+ linters.remove('pep8')
+ linters.append('pycodestyle')
options = parse_options(
linters=linters, force=1,
ignore=ignore,this would make the test passes, but it would break the |
Updating our submodules and trying to fix the errors that are showing up.
Also improve the shell scripts tests by linting the files and improving the visual output.