Skip to content

Rename doesn't provide "in_hierarchy" option #456

Closed

Description

@brakhane

Suppose I have the following code:

class A(object):
    def foo(self):
        pass

class A2(A):
    def foo(self):
        pass

class B(object):
    def foo(self):
        pass

If i want to rename A2's or A's "foo", ropevim provides me with the "in_hierarchy" option, which will also correctly rename foo in A (or A2 respectively), but not in B.

pymode doesn't seem to provide this, I only have the choice "perform", which will only rename the exact method, and not the corresponding one in the super-/subclasses. So I am forced to use ropevim for this kind of refactoring (and actually remember to do so)

It would be nice if pymode would give me this option as well.

Activity

  1. added a commit that references this issue on Jul 25, 2014
    b2de6b0
  2. brakhane commented on Jul 25, 2014

    @brakhane
    ContributorAuthor

    I've added a pull request. It's a quick hack, but it works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions