Fix macOS and Windows CI test failures

diraol · diraol · commit 340e73eca62f · 2025-11-17T11:56:33.000-03:00
macOS fixes:
- Replace mapfile with while loop (mapfile is bash 4+ only, macOS has bash 3.x/zsh)
- Fixes 'mapfile: command not found' error

Windows fixes:
- Add nobackup and nowritebackup to vimrc to prevent backup file errors
- Fix Windows path resolution issue with os.path.relpath (handles different drive letters)
- Create C:\tmp directory for test compatibility (/tmp/ paths in tests)
- Fixes E510 backup file errors and ValueError path resolution errors

These changes address the specific CI failures:
- macOS: exit code 127 (command not found)
- Windows: E510 backup errors, E212 /tmp/ path errors, ValueError drive letter errors
diff --git a/pymode/ruff_integration.py b/pymode/ruff_integration.py
@@ -390,7 +390,14 @@ def code_check():
     content = '\n'.join(env.curbuf) + '\n'
     file_path = env.curbuf.name
     
-    env.debug("Start ruff code check: ", os.path.relpath(file_path, env.curdir))
+    # Use relpath if possible, but handle Windows drive letter differences
+    try:
+        rel_path = os.path.relpath(file_path, env.curdir)
+        env.debug("Start ruff code check: ", rel_path)
+    except ValueError:
+        # On Windows, relpath fails if paths are on different drives
+        # Fall back to absolute path in this case
+        env.debug("Start ruff code check (abs path): ", file_path)
     
     # Run ruff check
     errors = run_ruff_check(file_path, content)
diff --git a/scripts/cicd/run_vader_tests_direct.sh b/scripts/cicd/run_vader_tests_direct.sh
@@ -149,7 +149,11 @@ log_info "Created CI vimrc at ${CI_VIMRC}"
 # Find test files
 TEST_FILES=()
 if [[ -d "tests/vader" ]]; then
-    mapfile -t TEST_FILES < <(find tests/vader -name "*.vader" -type f | sort)
+    # Use while read loop instead of mapfile for better compatibility (macOS bash/zsh)
+    # mapfile is bash 4+ only, macOS has bash 3.x or uses zsh
+    while IFS= read -r file; do
+        TEST_FILES+=("$file")
+    done < <(find tests/vader -name "*.vader" -type f | sort)
 fi
 
 if [[ ${#TEST_FILES[@]} -eq 0 ]]; then
diff --git a/scripts/cicd/run_vader_tests_windows.ps1 b/scripts/cicd/run_vader_tests_windows.ps1
@@ -35,6 +35,19 @@ Write-Info "Project root: $ProjectRoot"
 Write-Info "PowerShell version: $($PSVersionTable.PSVersion)"
 Write-Info "OS: $([System.Environment]::OSVersion.VersionString)"
 
+# Create /tmp symlink or directory for Windows compatibility
+# Some tests use /tmp/ paths which don't exist on Windows
+$TmpDir = $env:TEMP
+if (-not (Test-Path "C:\tmp")) {
+    # Try to create C:\tmp directory
+    try {
+        New-Item -ItemType Directory -Path "C:\tmp" -Force | Out-Null
+        Write-Info "Created C:\tmp directory for test compatibility"
+    } catch {
+        Write-Warn "Could not create C:\tmp, tests using /tmp/ may fail"
+    }
+}
+
 # Try python3 first, then python, then py
 $PythonCmd = $null
 if (Get-Command python3 -ErrorAction SilentlyContinue) {
@@ -120,6 +133,8 @@ set directory=
 set undodir=
 set viewdir=
 set noswapfile
+set nobackup
+set nowritebackup
 set paste
 set shell=cmd.exe
 
