Repository navigation
Do not flush a closed file from a read-mode LZ4 frame - #353
Open
CAOShurong wants to merge 1 commit into
Open
CAOShurong wants to merge 1 commit into
CAOShurong wants to merge 1 commit into
Conversation
LZ4FrameFile.flush() always flushed the underlying file. A buffered reader finalizes that call after the caller has closed the file, and Python 3.13 reports ValueError. Read mode now returns without touching the file. A write still finishes the open frame and flushes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LZ4FrameFile.flush() called the underlying file even in read mode. On Python 3.13, a buffered reader finalizes that flush after the caller has closed the file, and the process prints ValueError: I/O operation on closed file.
Read mode now returns without touching the underlying file. A write still finishes the open frame and flushes it.
The new tests failed on lz4 4.4.5 and pass after the change. pytest --cov=lz4/block --cov=lz4/frame tests/block tests/frame on Windows/Python 3.13.1: 19806 passed. flake8 lz4 setup.py tests passed with the project ignore list. A local pytest plugin was disabled because it imports requests, and TEMP was a writable directory. The stream tests and the docs build were not part of this run.
Fixes #351