Skip to content

Do not flush a closed file from a read-mode LZ4 frame - #353

Open
CAOShurong wants to merge 1 commit into
python-lz4:masterfrom
CAOShurong:fix-read-flush-closed-file
Open

CAOShurong wants to merge 1 commit into
python-lz4:masterfrom
CAOShurong:fix-read-flush-closed-file

Conversation

@CAOShurong

Copy link
Copy Markdown

LZ4FrameFile.flush() called the underlying file even in read mode. On Python 3.13, a buffered reader finalizes that flush after the caller has closed the file, and the process prints ValueError: I/O operation on closed file.

Read mode now returns without touching the underlying file. A write still finishes the open frame and flushes it.

The new tests failed on lz4 4.4.5 and pass after the change. pytest --cov=lz4/block --cov=lz4/frame tests/block tests/frame on Windows/Python 3.13.1: 19806 passed. flake8 lz4 setup.py tests passed with the project ignore list. A local pytest plugin was disabled because it imports requests, and TEMP was a writable directory. The stream tests and the docs build were not part of this run.

Fixes #351

LZ4FrameFile.flush() always flushed the underlying file. A buffered reader finalizes that call after the caller has closed the file, and Python 3.13 reports ValueError. Read mode now returns without touching the file. A write still finishes the open frame and flushes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LZ4FrameFile.flush() flushes the underlying file in read mode, so Python 3.13 prints "I/O operation on closed file" at garbage collection

1 participant