Fix module init error handling in block and stream modules#333
Open
devdanzin wants to merge 1 commit into
Open
Fix module init error handling in block and stream modules#333devdanzin wants to merge 1 commit into
devdanzin wants to merge 1 commit into
Conversation
…Object - Add Py_DECREF(module) before returning NULL when PyErr_NewExceptionWithDoc fails in both block and stream module init — previously leaked the module - Check PyModule_AddObject return value when adding LZ4BlockError and LZ4StreamError — previously ignored failures, leaking the exception ref Found using cext-review-toolkit (https://github.com/devdanzin/cext-review-toolkit). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Py_DECREF(module)before returning NULL whenPyErr_NewExceptionWithDocfails in both_blockand_streammodule init — previously leaked the module objectPyModule_AddObjectreturn value when addingLZ4BlockErrorandLZ4StreamError— previously ignored failures, leaking the exception class referenceContext
PyModule_AddObjectsteals a reference on success but not on failure. The previous code did not check its return value, so on failure thePy_INCREF'd exception class was leaked. The fix checks the return and decrefs both the exception and the module on failure.Note:
PyModule_AddObjectRef(Python 3.10+) would simplify this, but the project supports Python 3.9 so we usePyModule_AddObjectwith proper error checking.Found using cext-review-toolkit.
Note
This PR was authored and submitted by Claude Code (Anthropic).
It was reviewed by a human before submission.
Test plan