Skip to content

Correct the import of _compression for Python 3.14#303

Merged
jonathanunderwood merged 2 commits into
python-lz4:masterfrom
befeleme:py314
Oct 20, 2025
Merged

Correct the import of _compression for Python 3.14#303
jonathanunderwood merged 2 commits into
python-lz4:masterfrom
befeleme:py314

Conversation

@befeleme

@befeleme befeleme commented May 29, 2025

Copy link
Copy Markdown
Contributor

This is backwards compatible with all supported versions of Python.

Resolves: #302

@befeleme
Correct the import of _compression for Python 3.14
53819a9 
This is backwards compatible with all supported versions of Python.
@cclauss cclauss mentioned this pull request Sep 24, 2025
Merged
cclauss added a commit to cclauss/python-lz4 that referenced this pull request Sep 24, 2025
@cclauss
Build wheels for Python 3.14
31c69e9 
Caution: The new `compression` module in Python >= 3.14 Standard Library causes compatibility problems.
* https://docs.python.org/3.14/library/compression.html
* python-lz4#302 
* python-lz4#303
* python-lz4#308 

---
Python v3.14 -- October 7th
* https://www.python.org/download/pre-releases
* https://www.python.org/downloads/release/python-3140rc3
* https://docs.python.org/3.14/whatsnew/3.14.html

What's new in Python 3.14: ___PEP 784: Adding Zstandard to the standard library___
* https://docs.python.org/3.14/whatsnew/3.14.html#whatsnew314-pep784
This was referenced Sep 24, 2025
Merged
Closed
cclauss
cclauss reviewed Sep 24, 2025
View reviewed changes
Comment thread lz4/frame/__init__.py Outdated
@cclauss cclauss mentioned this pull request Sep 24, 2025
Closed
@taegyunkim

taegyunkim commented Oct 6, 2025

Copy link
Copy Markdown

Is there anything blocking merging this PR?

@befeleme @cclauss
Update lz4/frame/__init__.py
6d30c78 
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss

cclauss commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

@taegyunkim When you think a pull request is useful and ready to be merged, please consider giving it a positive review.

Every check mark ✔️ at the top right of this page gives project maintainers confidence that the proposed changes have been read through and deemed both useful and safe to merge into the codebase. Lots of 👍 and "what is the ETA?" comments are easier for maintainers to ignore than ✔️✔️✔️✔️✔️ from several different reviewers.

Anyone can review a pull request on GitHub. To do so here:

  1. Scroll to the top of this page.
  2. Click the Files changed tab and read through each file carefully looking for potential issues.
  3. Click the Review changes button.
  4. Click Approve (or one of the other options) and add comments only if they have not already been stated in the PR.
  5. Click Submit review so that your ✔️ will be added to the list.

@cclauss

cclauss commented Oct 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Python 3.14 (the π version) was released 30 minutes ago.
https://www.python.org/downloads/release/python-3140/
https://github.com/actions/python-versions/releases

@MichaelGrupp MichaelGrupp mentioned this pull request Oct 10, 2025
Merged
@cclauss

cclauss commented Oct 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@jonathanunderwood Six positive code reviews... Can you or another maintainer please review the proposed changes?

@emmatyping Your review, please.

@cclauss cclauss mentioned this pull request Oct 17, 2025
Merged
@jonathanunderwood

jonathanunderwood commented Oct 20, 2025

Copy link
Copy Markdown
Member

@jonathanunderwood Six positive code reviews... Can you or another maintainer please review the proposed changes?

Reviews by fly by folks are meaningless.

@emmatyping Your review, please.

See above.

@jonathanunderwood jonathanunderwood merged commit d838750 into python-lz4:master Oct 20, 2025
@befeleme befeleme deleted the py314 branch October 20, 2025 10:30
cclauss added a commit to cclauss/python-lz4 that referenced this pull request Oct 20, 2025
@cclauss
Build wheels for Python 3.14
000e412 
Caution: The new `compression` module in Python >= 3.14 Standard Library causes compatibility problems.
* https://docs.python.org/3.14/library/compression.html
* python-lz4#302 
* python-lz4#303
* python-lz4#308 

---
Python v3.14 -- October 7th
* https://www.python.org/download/pre-releases
* https://www.python.org/downloads/release/python-3140rc3
* https://docs.python.org/3.14/whatsnew/3.14.html

What's new in Python 3.14: ___PEP 784: Adding Zstandard to the standard library___
* https://docs.python.org/3.14/whatsnew/3.14.html#whatsnew314-pep784
jonathanunderwood pushed a commit that referenced this pull request Oct 20, 2025
@cclauss @jonathanunderwood
Build wheels for Python 3.14
8c82a0d 
Caution: The new `compression` module in Python >= 3.14 Standard Library causes compatibility problems.
* https://docs.python.org/3.14/library/compression.html
* #302 
* #303
* #308 

---
Python v3.14 -- October 7th
* https://www.python.org/download/pre-releases
* https://www.python.org/downloads/release/python-3140rc3
* https://docs.python.org/3.14/whatsnew/3.14.html

What's new in Python 3.14: ___PEP 784: Adding Zstandard to the standard library___
* https://docs.python.org/3.14/whatsnew/3.14.html#whatsnew314-pep784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanunderwood jonathanunderwood jonathanunderwood approved these changes

+5 more reviewers

@hroncok hroncok hroncok approved these changes

@cclauss cclauss cclauss approved these changes

@taegyunkim taegyunkim taegyunkim approved these changes

@MichaelGrupp MichaelGrupp MichaelGrupp approved these changes

@morbult morbult morbult approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImportError when attempting to test with Python 3.14

7 participants

@befeleme @taegyunkim @cclauss @jonathanunderwood @hroncok @MichaelGrupp @morbult