Skip to content

Text io #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanunderwood merged 2 commits into from
Apr 3, 2018
Merged

Text io #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b92766
Fix open function for text mode (#122)
jonathanunderwood Apr 3, 2018
582443d
Fix test for text IO on Python 2
jonathanunderwood Apr 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lz4/frame/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,9 +832,11 @@ def open(filename, mode="rb",
if newline is not None:
raise ValueError("Argument 'newline' not supported in binary mode")

_mode = mode.replace('t', '')

binary_file = LZ4FrameFile(
filename,
mode=mode,
mode=_mode,
block_size=block_size,
block_linked=block_linked,
compression_level=compression_level,
Expand Down
8 changes: 8 additions & 0 deletions tests/frame/test_frame_6.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ def test_lz4frame_open_write_read_defaults(data):
data_out = fp.read()
assert data_out == data

def test_lz4frame_open_write_read_text():
data = u'This is a test string'
with lz4frame.open('testfile', mode='wt') as fp:
fp.write(data)
with lz4frame.open('testfile', mode='rt') as fp:
data_out = fp.read()
assert data_out == data

def test_lz4frame_open_write_read(
data,
compression_level,
Expand Down