You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As someone only needing the linting part of ruff, I'd like to be able to disable the formatter, which conflicts with the formatter I do use.
I spent the better part of the day trying to figure out why black always broke the formatting when running inside of my editor but not when running from our pre-commit hook or manually in the terminal... Now I finally figured out that it was actually this plugin having formatting enabled by default.
Ruff formatting is not 100% compatible with black, which basically stops me from using this plugin entirely in my workflow. Which sucks because I do actually want the linting part of ruff.
Otherwise I guess I'll need to setup another language server for which I can then entirely disable document formatting
Activity
jhossbach commentedon Feb 22, 2024
Looking into it.
jhossbach commentedon Feb 22, 2024
Can you checkout https://github.com/python-lsp/python-lsp-ruff/tree/fix_%2383 and see if that resolves your issue? I tried locally with neovim and it seems to work.
AtomToast commentedon Feb 26, 2024
That resolves it for me 👍
AtomToast commentedon Feb 29, 2024
Any chance of getting this into a pr?
jhossbach commentedon Feb 29, 2024
Certainly, but I want to check if returning
Noneis valid as a formatting response before merging.jhossbach commentedon Mar 1, 2024
I think we are good to go:
https://github.com/microsoft/lsprotocol/blob/610626a4d32faee96302f5db385f14fa4bc1de95/packages/python/lsprotocol/types.py#L10805