ruff command line is missing subcommand when specifying executable in config

If the executable is specified in the LSP config, the command line to run ruff is constructed and executed in

Lines 517 to 519 in c018265

    
           cmd = [executable] 
        
           cmd.extend(arguments) 
        
           p = Popen(cmd, stdin=PIPE, stdout=PIPE, stderr=PIPE)

This call is missing the subcommand to actually execute with ruff. Compare to the call constructed for the fallback usage of the Python module in

python-lsp-ruff/pylsp_ruff/plugin.py

Lines 527 to 529 in c018265

    
           cmd = [sys.executable, "-m", "ruff", str(subcommand)] 
        
           cmd.extend(arguments) 
        
           p = Popen(cmd, stdin=PIPE, stdout=PIPE, stderr=PIPE)

which includes str(subcommand).

Without the subcommand ruff seems to fallback to linting and does nothing to the buffer when trying to format through the LSP. Just adding str(subcommand) to the executable command fixes this for me.

@dfn-certling

Hey @dfn-certling, thanks for the bug report! I will push a bugfix release today.

Navigation Menu

Repository navigation

ruff command line is missing subcommand when specifying executable in config #74

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	cmd = [executable]
	cmd.extend(arguments)
	p = Popen(cmd, stdin=PIPE, stdout=PIPE, stderr=PIPE)

	cmd = [sys.executable, "-m", "ruff", str(subcommand)]
	cmd.extend(arguments)
	p = Popen(cmd, stdin=PIPE, stdout=PIPE, stderr=PIPE)

ruff command line is missing subcommand when specifying executable in config #74

Description

Activity

jhossbach commented on Jan 12, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions