Skip to content

Conversation

@seruman
Copy link
Contributor

@seruman seruman commented Jun 5, 2023

skip_* options are set to False by default and plugin settings are ignored for these two options.

An alternative would be to accept all black.FileMode arguments as settings and pass as is.

@ccordoba12 ccordoba12 changed the title pylsp_black: read skip_* options from plugin settings Read skip options from plugin settings Jun 5, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @seruman for your contribution!

@ccordoba12 ccordoba12 added this to the v2.0.0 milestone Jun 5, 2023
@ccordoba12 ccordoba12 merged commit 527fd8f into python-lsp:master Jun 5, 2023
@seruman seruman deleted the load-skip-config branch June 9, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants