Conversation
droideck
requested changes
Sep 9, 2026
droideck
left a comment
droideck
left a comment
Member
There was a problem hiding this comment.
Looks good!
A couple of things before the merge and a tag:
- 3.4.6 and 3.4.7 release commits also bumped the version numbers in
__version__files accordingly. So I think we need to do it here too. - I also noticed we don't have SECURITY.md, CONTRIBUTING.rst, README.rst, .readthedocs.yaml, Doc/requirements.txt and Misc/python-ldap.supp (the Makefile's valgrind target uses the last one) in MANIFEST.in. And they were released in https://pypi.org/project/python-ldap/3.4.7/#files so I suspect the content just was in your venv when you were doing the build. IMO, worth adding the files explicitly so we can release with
python -m buildin isolation.
| @@ -1,5 +1,20 @@ | |||
| Released 3.4.8 (unreleased) | |||
Member
There was a problem hiding this comment.
The date is missing (but maybe you wanted to handle that later at the merge time)
mistotebe
force-pushed
the
prep_3.4.8
branch
from
September 9, 2026 14:15
ad9d39e to
77a4278
Compare
mistotebe
force-pushed
the
prep_3.4.8
branch
from
September 9, 2026 14:18
77a4278 to
f42ca18
Compare
Contributor
Author
True, I forgot we did that in the PR, and it makes more sense so done.
I didn't realise they would actually land in the source package. OK, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.