fix(extop.dds): make passing of requestName optional again #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requestName is already set at class member. It seems there is code out there which is not giving it as value but passing None. in that case, fallback to the class member. Fixes: 414ae1d
droideck
approved these changes
Oct 24, 2025
Contributor
droideck
left a comment
droideck
left a comment
There was a problem hiding this comment.
Looks good!
One note though, if someone explicitly passes requestName="", it will fallback to the class default. This is likely desired behavior, but worth noting.
We might make it more explicit:
if requestName is None: requestName = self.requestName But requestTtl already follows or patterns and I don't think any body would use it with "".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestName is already set at class member. It seems there is code out there which is not giving it as value but passing None. in that case, fallback to the class member.
Fixes: 414ae1d