Skip to content

fix(extop.dds): fix unset RefreshRequest.requestValue #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
droideck merged 1 commit into from
Oct 21, 2025
Merged

fix(extop.dds): fix unset RefreshRequest.requestValue #595

droideck merged 1 commit into from
Oct 21, 2025

Conversation

@spaceone
Copy link
Contributor

@spaceone spaceone commented Aug 14, 2025 

>>> from ldap.extop.dds import RefreshRequest
>>> req = RefreshRequest(RefreshRequest.requestName, 'uid=temp,dc=freeiam,dc=org', 86400)
>>> repr(req)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/ldap/extop/__init__.py", line 31, in __repr__
    return f'{self.__class__.__name__}({self.requestName},{self.requestValue})'
                                                           ^^^^^^^^^^^^^^^^^
AttributeError: 'RefreshRequest' object has no attribute 'requestValue'. Did you mean: 'requestName'?

@spaceone
fix(extop.dds): fix unset RefreshRequest.requestValue
8f3b326 
>>> from ldap.extop.dds import RefreshRequest
>>> req = RefreshRequest(RefreshRequest.requestName, 'uid=temp,dc=freeiam,dc=org', 86400)
>>> repr(req)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/ldap/extop/__init__.py", line 31, in __repr__
    return f'{self.__class__.__name__}({self.requestName},{self.requestValue})'
                                                           ^^^^^^^^^^^^^^^^^
AttributeError: 'RefreshRequest' object has no attribute 'requestValue'. Did you mean: 'requestName'?
droideck
droideck approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droideck droideck merged commit 414ae1d into python-ldap:main Oct 21, 2025
16 checks passed
@spaceone
Copy link
Contributor Author

spaceone commented Oct 21, 2025

ah, I'm sorry, I didn't consider code, which passes None for the requestName. Fixed in: #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droideck droideck droideck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spaceone @droideck