Conversation
fager
marked this pull request as draft
May 15, 2024 19:49
Contributor
|
Might be worthwhile to squash this into a single commit |
Contributor
|
Hi @fager, were you interested in finishing this PR (at least to support modrdn)? I can take over otherwise |
mistotebe
force-pushed
the
fager/change-567
branch
from
September 10, 2026 14:27
eb6c54d to
a3c0c22
Compare
mistotebe
marked this pull request as ready for review
September 10, 2026 14:28
droideck
requested changes
Sep 13, 2026
| deleteoldrdn = False | ||
| if k is not None: | ||
| if k.lower() == 'deleteoldrdn': | ||
| deleteoldrdn = (v == b'1') |
Member
There was a problem hiding this comment.
Could we require deleteoldrdn and validate that its value is exactly 0 or 1 before calling handle_modrdn? Just so stuff like deleteoldrdn: true or deleteoldrdn: 2 is not silently turned into False. Also the surrounding branches accept the field being absent.
IIUC, RFC 2849 makes this field mandatory.
So possibly we can raiseValueError for missing/invalid flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the parser for add and delete operations in LDIF change files for Issue #567