Skip to content

Issue #399: do not decode attribute values of post read control #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 2 commits into from
Dec 4, 2020
Merged

Issue #399: do not decode attribute values of post read control #400

encukou merged 2 commits into from
Dec 4, 2020

Conversation

@spaceone
Copy link
Contributor

@spaceone spaceone commented Nov 24, 2020

leave them bytes, as it's normal for attribute values.

@spaceone spaceone mentioned this pull request Nov 24, 2020
Closed
tiran
tiran reviewed Nov 24, 2020
View reviewed changes
@tiran
Copy link
Member

tiran commented Nov 24, 2020

Docs are auto-generated from code. autoclass also supports versionchanged syntax:

diff --git a/Doc/reference/ldap-controls.rst b/Doc/reference/ldap-controls.rst
index 1520b24..bd6737a 100644
--- a/Doc/reference/ldap-controls.rst
+++ b/Doc/reference/ldap-controls.rst
@@ -206,3 +206,6 @@ search.
 
 .. autoclass:: ldap.controls.readentry.PostReadControl
    :members:
+
+   .. versionchanged:: 4.0
+      Add text here

@spaceone spaceone force-pushed the read-control-encoding branch from 4741087 to dad3a48 Compare November 24, 2020 22:04
@spaceone
Copy link
Contributor Author

spaceone commented Nov 24, 2020

Ok, added a notice in the docs.

@spaceone
Copy link
Contributor Author

spaceone commented Nov 25, 2020

where do I find the built documentation?: https://travis-ci.org/github/python-ldap/python-ldap/jobs/745741979

droideck
droideck approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. You have my ack.

where do I find the built documentation?: https://travis-ci.org/github/python-ldap/python-ldap/jobs/745741979

You can build the PR locally and check the HTML pages.

The HTML pages are in .tox/doc/tmp/html.

@encukou encukou merged commit 4993d4a into python-ldap:master Dec 4, 2020
@encukou
Copy link
Member

encukou commented Dec 4, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran left review comments

@droideck droideck droideck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spaceone @tiran @encukou @droideck