Document the LDAPError fields #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, correct the note on COMPARE_FALSE and COMPARE_TRUE
tiran
reviewed
Jun 18, 2020
- All fields are optional and more fields may be added in the future - desc might not be English. It comes from ldap_err2string - info is server-specific - there is errno, no errnum
tiran
reviewed
Jun 18, 2020
Member
Author
|
Alright! Hopefully this wording explains it well. |
tiran
approved these changes
Jun 18, 2020
Member
tiran
left a comment
tiran
left a comment
There was a problem hiding this comment.
Much better than before, thanks! 👍
Member
Author
Mostly thanks to your comments! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the list of changfes, I realized the
LDAPErrorinfo dict if poorly documented. This should help.Also, this corrects the note on
COMPARE_FALSEandCOMPARE_TRUE, which was contradicting the'msgid'doc.