Skip to content

Conversation

@eyalch
Copy link

@eyalch eyalch commented Oct 24, 2019

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #307 into master will decrease coverage by 1.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   70.78%   69.38%   -1.40%     
==========================================
  Files          49       39      -10     
  Lines        4796     3172    -1624     
  Branches      804      484     -320     
==========================================
- Hits         3395     2201    -1194     
+ Misses       1062      822     -240     
+ Partials      339      149     -190     
Impacted Files Coverage Δ
Lib/ldap/compat.py 18.86% <0.00%> (-47.17%) ⬇️
Lib/ldap/ldapobject.py 66.66% <0.00%> (-9.73%) ⬇️
Lib/slapdtest/_slapdtest.py 77.25% <0.00%> (-7.75%) ⬇️
Lib/ldap/__init__.py 82.69% <0.00%> (-7.70%) ⬇️
Lib/ldap/functions.py 90.00% <0.00%> (-7.50%) ⬇️
Lib/ldap/dn.py 94.23% <0.00%> (-3.85%) ⬇️
Lib/ldap/sasl.py 77.77% <0.00%> (-2.78%) ⬇️
Lib/ldap/controls/deref.py 57.14% <0.00%> (ø)
Modules/constants_generated.h
Modules/common.c
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532ffc0...8ed3b60. Read the comment docs.

@encukou
Copy link
Member

encukou commented Jan 29, 2020

I assume it'll be the same in Debian Bullseye and newer ones. Right?
I think it would make sense to put tox in the instructions and have a note for older Debian versions.

Eyal Cherevatzki and others added 2 commits May 27, 2020 12:12
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Christian Heimes <christian@python.org>
@tiran
Copy link
Member

tiran commented May 27, 2020

Travis CI is blocked

@tiran tiran closed this May 27, 2020
@tiran tiran reopened this May 27, 2020
@tiran tiran merged commit 63058a0 into python-ldap:master May 28, 2020
@tiran tiran added the doc label May 28, 2020
@tiran tiran added this to the 3.3 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants