Codecov Report

Merging #291 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #291      +/-   ##
=========================================
+ Coverage   71.04%   71.1%   +0.06%     
=========================================
  Files          49      49              
  Lines        4817    4828      +11     
  Branches      812     813       +1     
=========================================
+ Hits         3422    3433      +11     
+ Misses       1061    1060       -1     
- Partials      334     335       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a593d...ab2097e. Read the comment docs.

FYI, I was getting this error:
ldap.SERVER_DOWN: {'desc': "Can't contact LDAP server", 'errno': 4, 'info': 'Interrupted system call'}
I think my server really is unreachable, and applying this patch now causes an infinite loop in my code.
So the while True probably should give up at some point.

I'm surprised that you're seeing consistent, repeated errno == EINTR with ldap.SERVER_DOWN ... why would that happen? We've been running with this patch for > 9 months and have never seen that.

I suppose it couldn't hurt to terminate the loop after some finite number of retries, but that sorta feels like it's covering up some other issue. If you can reproduce the behavior, it would be interesting to strace. Are you using OpenLDAP?

@dmulder Which server are you using?

No response :(
@rgbyrnes, would you mind terminating the loop? An exception is better than infinite loop – especially since this code has no tests.

Still no response :(
Please re-open this if you have any additional information.