Additional exception fields#288
Merged
encukou merged 7 commits intopython-ldap:masterfrom Jun 5, 2020
Merged
Conversation
|
LGTM regarding #208 . |
Contributor
Author
Member
|
This is out of my depth. |
Contributor
Author
|
Any ideas on a review? Without this it's impossible to have more than one operation pending on a connection. |
Member
|
My review will be sub-par, but it looks like I'll need to do it to move this forward. I'll dedicate a day next week to python-ldap. |
Contributor
Author
|
Thanks, I'll rebase it in the meantime. |
82f050b to
8492b16
Compare
Contributor
Author
|
Only fails on the same doctest as master now. |
Member
|
The last commit should go into a separate PR:
|
encukou
reviewed
May 6, 2020
Contributor
Author
|
I've moved the WIP commit into its own branch, but kept the |
encukou
approved these changes
Jun 5, 2020
Member
encukou
left a comment
There was a problem hiding this comment.
Looks good!
Thank you for the change, and apologies for the delay in reviewing.
This was referenced Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work to improve how we raise exceptions on result, deals with controls and msgid being missing (#177, #208).
Ready for merging (pending #282, #283, #284 have been accepted) apart from last commit which is mainly here for initial review and can be split into its own PR if you want.