Get rid of expected failures in tokenizer tests #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 71.1% 71.11% +<.01%
==========================================
Files 49 49
Lines 4818 4819 +1
Branches 812 812
==========================================
+ Hits 3426 3427 +1
- Misses 1056 1057 +1
+ Partials 336 335 -1
Continue to review full report at Codecov.
|
Member
|
I am out of my depth here: the details of LDAP tokenization and Oracle Internet Directory escape me :( |
encukou
approved these changes
Jan 29, 2020
Member
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
No response :(
I can't find an issue here. Existing tests pass and expected failures are solved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the failures actually stems from using the wrong method. Extending the tokenizer to deal with escapes gets rid of the other.