Store message id for exceptions raised from result4()#262
Store message id for exceptions raised from result4()#262encukou merged 2 commits intopython-ldap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 71.38% 71.42% +0.04%
==========================================
Files 49 49
Lines 4837 4837
Branches 808 808
==========================================
+ Hits 3453 3455 +2
+ Misses 1050 1048 -2
Partials 334 334
Continue to review full report at Codecov.
|
|
Is there any chance of getting this pull request merged? We're using this in production and are forced to use a patched build of python-ldap because of this. I was sorry to see that a new version has been released without any of the pull requests opened for the project being merged. I think this is really discouraging for 3rd party contributors... |
|
Indeed, there's a shortage of contributor time. Sorry for that! The last release had quite a few pull requests merged. Sorry that yours was one of the ones that didn't make it – when the critical bugfix was reviewed, I took everything that was merged until then. |
Still the case. This PR is missing tests and documentation. Would you care to add them? |
krisztian-kovacs
force-pushed
the
message-id-in-exception
branch
2 times, most recently
from
ee3ed13 to
d3d0dc3
Compare
|
I've updated the patch with docs and tests. Also, I've found out that this would probably fix #177. |
|
Thank you for the update, and apologies again for not finding time to review the pull request. Compared to this pull request, the key is named I would still like to merge the tests and documentation from this pull request, though. I will rebase, update and merge it. |
encukou
force-pushed
the
message-id-in-exception
branch
from
d3d0dc3 to
fff2905
Compare
encukou
force-pushed
the
message-id-in-exception
branch
from
fff2905 to
e2bcd62
Compare
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
For some reason, Travis CI is not reporting results. But the build for e2bcd62 passed: https://travis-ci.org/github/python-ldap/python-ldap/builds/695122368
|
Thanks for finally merging a solution for this. |
3 participants
Otherwise calling result4() can return exceptions like NO_SUCH_OBJECT or
COMPARE_TRUE without the caller being able to find the matching asynchronous
operation that failed.
This change adds the message id as an argument to the exception.