Skip to content

Conversation

@gabrielbriones
Copy link
Contributor

@codecov
Copy link

codecov bot commented Mar 15, 2018

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   70.25%   70.25%           
=======================================
  Files          49       49           
  Lines        4811     4811           
  Branches      810      810           
=======================================
  Hits         3380     3380           
  Misses       1098     1098           
  Partials      333      333
Impacted Files Coverage Δ
Lib/slapdtest/_slapdtest.py 82.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97aa653...65a23f8. Read the comment docs.

@tiran
Copy link
Member

tiran commented Mar 15, 2018

LGTM

Please add Closes: https://github.com/python-ldap/python-ldap/issues/189 to your commit message.

@encukou encukou merged commit fd0ec90 into python-ldap:master Mar 15, 2018
@encukou
Copy link
Member

encukou commented Mar 15, 2018

Thank you for sharing the fix, @gabrielbriones!


Please add Closes: https://github.com/python-ldap/python-ldap/issues/189 to your commit message.

I did that when squashing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants